Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resize filesystem when restore a snapshot to larger size volume #753

Merged

Conversation

AndyXiangLi
Copy link
Contributor

@AndyXiangLi AndyXiangLi commented Feb 18, 2021

Is this a bug fix or adding new feature?
Fixes: #569
What is this PR about? / Why do we need it?
continue from #595
Before NodePublishVolume, we will check if the device size is matched with the usable filesystem size. And resize the filesystem if there is a mismatch
TODO: Upstream is planning on move the common resize code to kubernetes/mount-util, #99223, we should use the resize function from there instead of maintaining our own once the changes are available
What testing is done?
Test done in both ext[x] and xfs filesystem

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 18, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @AndyXiangLi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 18, 2021
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 18, 2021
@coveralls
Copy link

coveralls commented Feb 19, 2021

Pull Request Test Coverage Report for Build 1887

  • 57 of 109 (52.29%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-1.3%) to 79.228%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/driver/node.go 7 14 50.0%
pkg/driver/mount.go 50 95 52.63%
Totals Coverage Status
Change from base Build 1886: -1.3%
Covered Lines: 1949
Relevant Lines: 2460

💛 - Coveralls

@gnufied
Copy link
Contributor

gnufied commented Feb 19, 2021

This is similar to #595 cc @jsafrane

@ayberk
Copy link
Contributor

ayberk commented Feb 22, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 22, 2021
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 12, 2021
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: AndyXiangLi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 8, 2021
@AndyXiangLi AndyXiangLi force-pushed the restore-smaller-snapshot branch 8 times, most recently from 8b55a14 to 8c7b5b9 Compare April 23, 2021 17:29
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Apr 23, 2021
@AndyXiangLi AndyXiangLi force-pushed the restore-smaller-snapshot branch 2 times, most recently from 2240d16 to 68d0eda Compare April 23, 2021 17:38
@AndyXiangLi
Copy link
Contributor Author

/test pull-aws-ebs-csi-driver-verify

@AndyXiangLi AndyXiangLi merged commit f1ad3b1 into kubernetes-sigs:master Apr 23, 2021
@gnufied
Copy link
Contributor

gnufied commented Apr 24, 2021

@AndyXiangLi did you merge it intentionally? I don't think it was reviewed. :-) cc @wongma7

@AndyXiangLi
Copy link
Contributor Author

@AndyXiangLi did you merge it intentionally? I don't think it was reviewed. :-) cc @wongma7

We talked about this offline and decide to merge it for now. Will update once the upstream is merged
kubernetes/kubernetes#101253

@wongma7
Copy link
Contributor

wongma7 commented Apr 26, 2021

(retroactive)
/lgtm

yea, let's merge stuff only when lgtm + approve present. I frequently manually merge stuff when those are present in case coveralls is bugged (it's already marked NOT required, but prow bot treats it as required for some reason), otherwise no reason to manual merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resizing disk partition in EBS from smaller snapshot size
6 participants