Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increased the helm chart version #980

Merged
merged 1 commit into from
Jul 22, 2021

Conversation

nirmalaagash
Copy link
Contributor

@nirmalaagash nirmalaagash commented Jul 21, 2021

Is this a bug fix or adding new feature?
No, Bumped up the the helm chart version

What is this PR about? / Why do we need it?
Change in helm chart version because, the PR #978 after merge had thrown message "Error: error creating GitHub release helm-chart-aws-ebs-csi-driver-2.0.0: POST https://api.github.com/repos/kubernetes-sigs/aws-ebs-csi-driver/releases: 422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]". Since the changes were done in the helm chart in PR #978, apparently the helm chart version should be also be increased.

What testing is done?
No testing required.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 21, 2021
@k8s-ci-robot
Copy link
Contributor

Hi @nirmalaagash. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 21, 2021
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jul 21, 2021
@vdhanan
Copy link
Contributor

vdhanan commented Jul 21, 2021

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 21, 2021
@AndyXiangLi
Copy link
Contributor

Why are you making this change? Can you provide more context?

@nirmalaagash
Copy link
Contributor Author

@AndyXiangLi Because, the PR #978 after merge had thrown message "Error: error creating GitHub release helm-chart-aws-ebs-csi-driver-2.0.0: POST https://api.github.com/repos/kubernetes-sigs/aws-ebs-csi-driver/releases: 422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]". Since the changes were done in the helm chart in PR #978, apparently the helm chart version should be also be increased.

@vdhanan
Copy link
Contributor

vdhanan commented Jul 22, 2021

@AndyXiangLi Because, the PR #978 after merge had thrown message "Error: error creating GitHub release helm-chart-aws-ebs-csi-driver-2.0.0: POST https://api.github.com/repos/kubernetes-sigs/aws-ebs-csi-driver/releases: 422 Validation Failed [{Resource:Release Field:tag_name Code:already_exists Message:}]". Since the changes were done in the helm chart in PR #978, apparently the helm chart version should be also be increased.

can you add this to the PR description, in response to the question "Why do we need it?"

@vdhanan
Copy link
Contributor

vdhanan commented Jul 22, 2021

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 22, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nirmalaagash, vdhanan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 22, 2021
@k8s-ci-robot k8s-ci-robot merged commit 9296c46 into kubernetes-sigs:master Jul 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants