-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provider support to pass custom labels to the Helm Chart #1240
Comments
That's duplicate of earlier #1237 |
Thanks @den-pluto . But this PR is different as it adds labels to deployments and service account as well. But the other PR adds labels to pods and nodes. So they share some common resources but not the same. This PR cover more resources that #1237 . |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
@rajramo61 Thank you for your PR, we will work on reviewing the changes |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues. This bot triages un-triaged issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close not-planned |
@k8s-triage-robot: Closing this issue, marking it as "Not Planned". In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Is your feature request related to a problem?/Why is this needed
aws-efs-csi-driver helm chart does not support custom labels. These metadata properties can provide some very useful information for the teams who use it.
/feature
Describe the solution you'd like in detail
Provide and option for passing commonLabel from values.yaml to the resources.
Describe alternatives you've considered
Other than chart name which is used as selector, there is no other way to pass custom labels to the chart.
Without making changes to helm chart, use kustomize to add labels as postRenderer or need to write mutating webhook in cluster to add the custom labels. But if we have option in helm chart itself then it makes this process very easy.
Additional context
aws-ebs-csi-driver helm chart provides this option. Here is the reference.
The text was updated successfully, but these errors were encountered: