Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e tests #32

Closed
2 of 3 tasks
leakingtapan opened this issue Mar 23, 2019 · 8 comments
Closed
2 of 3 tasks

Add e2e tests #32

leakingtapan opened this issue Mar 23, 2019 · 8 comments
Assignees
Milestone

Comments

@leakingtapan
Copy link
Contributor

leakingtapan commented Mar 23, 2019

Is your feature request related to a problem? Please describe.
We should add e2e test for supported features:

  • static provisioning
  • RWX mode from multiple pods
  • encryption in transit
@leakingtapan leakingtapan added this to the beta milestone Mar 23, 2019
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2019
@leakingtapan
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 24, 2019
@wongma7
Copy link
Contributor

wongma7 commented Jul 18, 2019

/assign
I'll write tests.
Integrating them with CI is a different story.

@wongma7
Copy link
Contributor

wongma7 commented Jul 19, 2019

Running upstream e2e tests works, but we should skip Disruptive for now.
"static provisioning", we get for free.
"encryption in transit", maybe, depending on how much we want to test. Is checking that mount option "tls" is present sufficient?

Summarizing 2 Failures:

[Fail] EFS CSI [Driver: efs.csi.aws.com] [Testpattern: Pre-provisioned PV (default fs)] subPath [It] should unmount if pod is gracefully deleted while kubelet is down [Disruptive][Slow][LinuxOnly]
/Users/mattwon/go/src/github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e/vendor/k8s.io/kubernetes/test/e2e/storage/utils/utils.go:212

[Fail] EFS CSI [Driver: efs.csi.aws.com] [Testpattern: Pre-provisioned PV (default fs)] subPath [It] should unmount if pod is force deleted while kubelet is down [Disruptive][Slow][LinuxOnly]
/Users/mattwon/go/src/github.com/kubernetes-sigs/aws-efs-csi-driver/test/e2e/vendor/k8s.io/kubernetes/test/e2e/storage/utils/utils.go:212

Ran 24 of 142 Specs in 1192.911 seconds
FAIL! -- 22 Passed | 2 Failed | 0 Pending | 118 Skipped
--- FAIL: TestEFSCSI (1192.91s)

@leakingtapan
Copy link
Contributor Author

leakingtapan commented Jul 19, 2019

Integrating them with CI is a different story.

SGTM. Let's create a different issue to track this if you are going to focus on e2e test case for this issue.

Is checking that mount option "tls" is present sufficient?

This is the least we can do, but this approach also provides the least value. Can we do better?

@wongma7
Copy link
Contributor

wongma7 commented Jul 19, 2019

'should concurrently access the single volume from pods on different node' will cover RWX mode from multiple pods.

Will look into other ways to verify traffic is actually encrypted. May be tricky, might need to start a privileged pod on the node to for example check if there is an stunnel process for the mount

@leakingtapan
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@leakingtapan: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

RomanBednar pushed a commit to RomanBednar/aws-efs-csi-driver that referenced this issue Feb 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants