Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create PV at subpath within filesystem #46

Closed
wreed4 opened this issue Jun 18, 2019 · 1 comment · Fixed by #52
Closed

Create PV at subpath within filesystem #46

wreed4 opened this issue Jun 18, 2019 · 1 comment · Fixed by #52
Assignees
Milestone

Comments

@wreed4
Copy link

wreed4 commented Jun 18, 2019

Is your feature request related to a problem? Please describe.
Currently, it seems that the view of the csi driver is that when you make a PV using an efs handle, that PV should represent the entire EFS filesystem. This means that if you create two PVs pointing to the same efs handle, both PVs will contain all files on the filesystem and a file written to one PV will show up in another.

Describe the solution you'd like in detail
This seems entirely contrary to the idea of a Volume to me. When you ask for a volume using EBS as the backing storage, this is not the behavior. The entire EBS volume is not mounted for your use. Instead, an area inside the EBS disk is reserved for pods to mount. It is expected that when you create a new PV, it will be empty and that other PVs are different volumes. Not two pointers to the same underlying volume. I would expect the EFS storage type to work the same way.

Describe alternatives you've considered
If for some reason, the current behavior is desired (it seems like the only use-case here would be sharing storage across namespaces which seems like a bad idea in general), then a mountPath could be added to the pv.spec.csi.volumeAttributes mapping. This field would allow a user to specify a particular subpath specifically for that PV. If left blank, the behavior would continue as-is unchanged.

Additional context
It may be worth noting that the efs-provisioner works in this way - PVs provisioned with it are distinct and do not share files even though they are backed by the same EFS filesystem. Users porting from the provisioner to csi will likely find this difference in behavior surprising (as I have).

@leakingtapan leakingtapan added this to the beta milestone Jun 19, 2019
@wongma7
Copy link
Contributor

wongma7 commented Jul 17, 2019

There definitely needs to be support for a Path field somewhere in VolumeAttributes equivalent to the Path field in an NFS PV VolumeSource.

/assign

RomanBednar pushed a commit to RomanBednar/aws-efs-csi-driver that referenced this issue Oct 10, 2023
OCPBUGS-17281: UPSTREAM: 1089: Bump golang.org/x/net/html to fix CVE-2023-3978
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants