Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow to don't use helm hooks for CSIDriver creation #1074

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

feat: allow to don't use helm hooks for CSIDriver creation #1074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions charts/aws-efs-csi-driver/templates/csidriver.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,10 @@ kind: CSIDriver
metadata:
name: efs.csi.aws.com
annotations:
{{- if .Values.useHelmHooksForCSIDriver }}
"helm.sh/hook": pre-install, pre-upgrade
"helm.sh/hook-delete-policy": before-hook-creation
{{- end }}
"helm.sh/resource-policy": keep
spec:
attachRequired: false
7 changes: 5 additions & 2 deletions charts/aws-efs-csi-driver/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ controller:
runAsGroup: 0
fsGroup: 0


## Node daemonset variables

node:
Expand Down Expand Up @@ -132,7 +131,8 @@ node:
# cpu: 100m
# memory: 128Mi
nodeSelector: {}
updateStrategy: {}
updateStrategy:
{}
# Override default strategy (RollingUpdate) to speed up deployment.
# This can be useful if helm timeouts are observed.
# type: OnDelete
Expand Down Expand Up @@ -180,3 +180,6 @@ storageClasses: []
# basePath: "/dynamic_provisioning"
# reclaimPolicy: Delete
# volumeBindingMode: Immediate

# Specifies wether to use helm hooks to apply the CSI driver
useHelmHooksForCSIDriver: true