-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ensureUniqueDirectory paramater at docs #1133
Conversation
I notice the name for `ensureUniqueDirectory` is wrong in the README, its correct at the example, but wrong here.
|
Welcome @wilkerlucio! |
Hi @wilkerlucio. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/ok-to-test |
Hi @wilkerlucio, thanks for the PR. We will merge it. |
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, wilkerlucio The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I noticed the name for
ensureUniqueDirectory
is wrong in the README, its correct at the example, but wrong here.Is this a bug fix or adding new feature?
Fix in docs
What is this PR about? / Why do we need it?
The current docs mislead the parameter due to the wrong naming