Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose env, volume, and volume mounts in helm chart for the efs controller and deamonset #1165

Conversation

cnmcavoy
Copy link
Contributor

Is this a bug fix or adding new feature?
New Feature

What is this PR about? / Why do we need it?
Allows configuring the EFS CSI Controller and Daemonset for IRSA in helm values without relying on the IRSA webhook being installed and configured in a cluster.

What testing is done?
helm template produces the expected output.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 18, 2023
@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2023
@cnmcavoy cnmcavoy force-pushed the cnmcavoy/helm-volumes-and-mounts branch from faf5665 to d27086b Compare January 12, 2024 20:37
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2024
@Helcaraxan
Copy link

Would love to see this get merged. It would be really useful to inject IAM configuration for non-EKS clusters.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 20, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 19, 2024
Copy link
Contributor

@seanzatzdev-amazon seanzatzdev-amazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @cnmcavoy , please undo changes to the versions in charts/aws-efs-csi-driver/CHANGELOG.md and charts/aws-efs-csi-driver/Chart.yaml, as we update these values as part of our release process

@cnmcavoy cnmcavoy force-pushed the cnmcavoy/helm-volumes-and-mounts branch from d27086b to 142a464 Compare April 19, 2024 19:49
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 19, 2024
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 19, 2024
@hazmat345
Copy link

+1 ... this would be very helpful

@slambrose
Copy link

+1 , hoping this can get merged very soon.

@cnmcavoy
Copy link
Contributor Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 25, 2024
@slambrose
Copy link

Is there an ETA for this?

@hazmat345
Copy link

This is currently a blocking issue for me - I need to use a different CA certificate bundle when talking to the AWS API in my environment. Until this feature is merged I have no way to overwrite the CA bundle in the controller pods with the updated bundle I need to use.

Would it help to create an issue to track this?

@slambrose
Copy link

{{ ping }}

@hazmat345
Copy link

Issue created: #1349

@hazmat345
Copy link

@seanzatzdev-amazon it looks like the changes requested in this PR have been made - would you mind giving this another look? Thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cnmcavoy, seanzatzdev-amazon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@seanzatzdev-amazon
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@seanzatzdev-amazon seanzatzdev-amazon merged commit 38dc9b8 into kubernetes-sigs:master May 21, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants