Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make gid allocator work with cross account feature #1199

Merged

Conversation

RomanBednar
Copy link
Contributor

Is this a bug fix or adding new feature?

Bug.

What is this PR about? / Why do we need it?

Cross account feature is broken. GID allocator must use localCloud created during CreateVolume which takes cross account feature into account. Without this change the driver attempts to list/describe access points and fails:

  Warning  ProvisioningFailed  29m (x6 over 47m)  efs.csi.aws.com_ip-10-0-30-56_e49a0a8c-a449-4a7c-bee5-9113112cd270  (combined from similar events): failed to provision volume with StorageClass "efs-crossaccount-sc": rpc error: code = Internal desc = Failed to discover used GIDs for filesystem: fs-04cbcb7d2b03a38a4: failed to list access points: FileSystemNotFound: File system 'fs-04cbcb7d2b03a38a4' does not exist.
{
  RespMetadata: {
    StatusCode: 404,
    RequestID: "1474ec74-cd0c-4a4d-b363-f792418b7e35"
  },
  ErrorCode: "FileSystemNotFound",
  Message_: "File system 'fs-04cbcb7d2b03a38a4' does not exist."
}

What testing is done?

Unit tests + manual testing including cross account configuration described here: https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/1203d4163e777b421617288fb5769203d3239d33/examples/kubernetes/cross_account_mount/README.md

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 21, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 21, 2023
@jsafrane
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 23, 2023
@jsafrane
Copy link
Contributor

/assign @mskanth972 @Ashley-wenyizha
for approval

@mskanth972
Copy link
Contributor

/lgtm

@mskanth972
Copy link
Contributor

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mskanth972, RomanBednar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 24, 2023
@k8s-ci-robot k8s-ci-robot merged commit 9530c7d into kubernetes-sigs:master Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants