-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump aws-sdk to 1.50 for EKS Pod Identity support #1254
Conversation
Welcome @askulkarni2! |
Hi @askulkarni2. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@justinsb / @seanzatzdev-amazon any help to unblock this PR? |
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to leave the "vendor/k8s.io/kubernetes/" in front of these filepaths, otherwise e2e tests will fail locally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments I left on vendor/k8s.io/kubernetes/test/e2e/storage/testsuites/provisioning.go
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: askulkarni2, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Is this a bug fix or adding new feature?
Fixes #1257. Bumps up aws-sdk-go to v1.50.3.
What is this PR about? / Why do we need it?
AWS SDK v.1.47.11 updated credential provider logic support which is required by pods which need to use the newly launched Amazon EKS Pod Identities.
Also see https://docs.aws.amazon.com/eks/latest/userguide/pod-id-minimum-sdk.html for further information.
What testing is done?
make
andmake test
.