Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick for new release v1.7.6 #1278

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Cherry-pick for new release v1.7.6 #1278

merged 2 commits into from
Feb 28, 2024

Conversation

mjsoyeon
Copy link
Contributor

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
Cherry-pick for new release v1.7.6

What testing is done?

ashrayjain and others added 2 commits February 28, 2024 16:47
@ashrayjain @mjsoyeon
Fix check for gid being less than 0
582592a 
We were checking the uid instead of the gid when we check the configured value against 0
@RyanStan @mjsoyeon
Disable efs-utils version check
e46af3f 
A "version check" feature was introduced into v1.35.1 of efs-utils. This
check runs once an hour and may result in the watchdog process making
API calls to Github. This commit disables this feature.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 28, 2024
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 28, 2024
@k8s-ci-robot
Copy link
Contributor

Hi @mjsoyeon. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2024
torredil
torredil approved these changes Feb 28, 2024
View reviewed changes
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 28, 2024
@Ashley-wenyizha
Copy link
Contributor

Could you point to me where is the commit to Update efs-csi-driver to use efs-utils latest release v1.35.2 as updated in pre-release PR? thanks

@mjsoyeon
Copy link
Contributor Author

Could you point to me where is the commit to Update efs-csi-driver to use efs-utils latest release v1.35.2 as updated in pre-release PR? thanks

https://github.com/aws/efs-utils/releases/tag/v1.35.2

@Ashley-wenyizha
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ashley-wenyizha, mjsoyeon, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 28, 2024
@mjsoyeon
Copy link
Contributor Author

/merge

@k8s-ci-robot k8s-ci-robot merged commit 7d87370 into kubernetes-sigs:release-1.7 Feb 28, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@torredil torredil torredil approved these changes

@d-nishi d-nishi Awaiting requested review from d-nishi

@wongma7 wongma7 Awaiting requested review from wongma7

Assignees

@Ashley-wenyizha Ashley-wenyizha

@torredil torredil

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mjsoyeon @k8s-ci-robot @Ashley-wenyizha @torredil @ashrayjain @RyanStan