Sanitize CSI RPC request logs #1363
Merged
+90
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
approved
|
/test pull-aws-efs-csi-driver-unit |
mskanth972
force-pushed
the
sanitize_secrets
branch
from
4b19377
to
d6de328
Compare
seanzatzdev-amazon
approved these changes
Jun 3, 2024
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mskanth972, seanzatzdev-amazon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Security enhancement
What is this PR about? / Why do we need it?
This PR addresses the potential risk of sensitive information being inadvertently logged, despite the EFS CSI Driver not supporting Token Requests. The primary change involves introducing a new utility function called SanitizeRequest. This function accepts a request object and returns a duplicate with the "Secrets" field emptied. It achieves this by creating a new instance of the request object's type, copying all fields from the original request to the new instance, and resetting the "Secrets" field to an empty map, if present.
What testing is done?