-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Directory provisioning #1408
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bertinatto The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
As a first step towards introducing a new provisioning method we need to introduce a new Interface called Provisioner. This allows us to simply call the Provision() method on structs that implement this interface, meaning we can expand the supported methods. This also means we can pull the GidAllocator out of the driver and into the AccessPointProvisioner which necessitated some test changes. GidAllocator may well move back into the driver later on as we may well need to share it across the different provisioners.
…sioning Now that we have the interface we can move Deletion behind an interface method too. Now the stage is set to start refactoring the tests in controller_test.go as they cover a lot that isn't actually necessary and could be tested via the provisioner
…tests closer to the provisioner
This is an ongoing effort to rebase #732.