-
Notifications
You must be signed in to change notification settings - Fork 564
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix creation of multiple storage classes in Helm chart #388
Fix creation of multiple storage classes in Helm chart #388
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Welcome @NilsGriebner! |
Hi @NilsGriebner. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
CLA signed |
/lgtm thanks! I will cherry-pick this into the release-1.2 branch for inclusion in a 1.2.x helm chart later, unless you wish to do it. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: NilsGriebner, wongma7 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Thanks for your quick response. Feel free to pick it! |
Is this a bug fix or adding new feature?
This is a bug fix for #387
What is this PR about? / Why do we need it?
The PR adds yaml separators to the storageclass template, so that helm can create all storageclasses specified
in
values.yaml
What testing is done?
Applied the changed chart against my local k8s cluster. The outcome was