Added flag for version information output #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/M
Closed
There was a problem hiding this comment.
Thx for the PR. could you refer to this PR in EBS CSI driver: kubernetes-sigs/aws-ebs-csi-driver@182211d for the sake of consistency ?
k8s-ci-robot
added
size/L
|
I've added a test and made the implementation more closely match that of the sister-ebs implementation for consistency |
|
thx for making the change. /lgtm |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: djcass44, leakingtapan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
jsafrane
pushed a commit
to jsafrane/aws-efs-csi-driver
that referenced
this pull request
Aug 10, 2023
…ERS-and-OWNERS_ALIASES OCPBUGS-16783: Chore: Update OWNERS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
Fixes: #25
What is this PR about? / Why do we need it?
This PR adds the ability to run the built binary with
--versionwhich prints some information about the application:What testing is done?
make verifymake testdocker build -t aws-efs-csi-test . && docker run aws-efs-csi-test --version(to ensure no pollution from my workspace)Assumptions
Since the Makefile contained
GOOS=linuxI didn't add any portability for getting this information on non-Linux platforms.Please let me know if you wish for me to change the names of any of the json fields or the way that the date is formatted.