Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it? It's not clear if the reaper is needed , the watchdog should be responsible for terminating/cleaning up stunnel processes. https://github.com/aws/efs-utils/blob/f3bb4a228a40bcf2e82fc28ab898d2b44ed8b05e/src/watchdog/__init__.py#L608-L642 .
I guess if the watchdog restarts then zombie stunnel processes might need to be reaped?edit: i dont think zombies can happen actually, the stunnel processes should still be running and their PID is stored in state file, so watchdog should figure out again that they are still running and not spawn another stunnel.But we are hearing about issues where mount fails with 'wait: no child processes' and I suspect this reaper is to blame, it might be racing with os.Command in mount_linux.go https://github.com/kubernetes/mount-utils/blob/19c6fae41ad49f3e4026f28b043f41343aa852fd/mount_linux.go#L176, I can't think of any other explanation for this weird error.
original PR adding reaper #113
What testing is done?