Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to golang 1.12 #70

Merged
merged 1 commit into from
Aug 20, 2019
Merged

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Aug 12, 2019

Is this a bug fix or adding new feature?
Fixes: #72

What is this PR about? / Why do we need it?
copy of kubernetes-sigs/aws-ebs-csi-driver#329 for EBS

What testing is done?
CI

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 12, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wongma7
To complete the pull request process, please assign leakingtapan
You can assign the PR to them by writing /assign @leakingtapan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 12, 2019
@wongma7
Copy link
Contributor Author

wongma7 commented Aug 13, 2019

/retest

@leakingtapan
Copy link
Contributor

depends on the fix at #55

@leakingtapan
Copy link
Contributor

/retest

@leakingtapan leakingtapan merged commit 73b217d into kubernetes-sigs:master Aug 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to golang 1.12
3 participants