-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for additional pod labels #926
Conversation
|
Hi @jaygridley. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
/remove-lifecycle stale |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hello @nckturner and @wongma7 can we please get a review here? |
This change seems very straight forward and would help the thousands of users who are trying to do cost management and attribution for different aspects using labels. Many of our cost and inventory reporting tools use labels to do aggregation and visibility and labels are the way we can do that with ease. Thank you for creating this recommendation and it seems like the Helm way to do this for Pods. |
Can we please get a review on this? This feature will be so helpful for us |
@nckturner, @wongma7 any chance you can look into that? |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
Does anyone know hot to expedite this PR? @jaygridley are you still working on this? |
2ff44b4
to
0cabb72
Compare
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jaygridley The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Martin Odstrcilik <martin.odstrcilik@gmail.com>
0cabb72
to
126b918
Compare
Work from this PR was already done in 3a87e1d and |
Is this a bug fix or adding new feature?
Feature
What is this PR about? / Why do we need it?
Extends Helm chart with additional Pod labels capability
What testing is done?
Locally generated template from the Helm chart