Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SSH from CI && bump K8S_VERSION for test cluster #986

Closed

Conversation

Ashley-wenyizha
Copy link
Contributor

@Ashley-wenyizha Ashley-wenyizha commented Apr 27, 2023

Is this a bug fix or adding new feature?
Fix for test cluster creating failure in PR tests as SSH access is unnecessary for CI and introduces a potential flake point.

Will separate this PR into 2, one for remove SSH and the other for version upgrade
What is this PR about? / Why do we need it?

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 27, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Ashley-wenyizha

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 27, 2023
Update kops.sh

remove ssh key path under eksctl test cluster
@RyanStan
Copy link
Contributor

RyanStan commented May 2, 2023

What's the reason for adding name: CSI_NODE_NAME as an env variable?

@Ashley-wenyizha Ashley-wenyizha changed the title Remove SSH from CI Remove SSH from CI && bump K8S_VERSION for test cluster May 3, 2023
@k8s-ci-robot
Copy link
Contributor

@Ashley-wenyizha: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-efs-csi-driver-external-test-eks 18e28b6 link true /test pull-aws-efs-csi-driver-external-test-eks
pull-aws-efs-csi-driver-e2e 18e28b6 link true /test pull-aws-efs-csi-driver-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@Ashley-wenyizha
Copy link
Contributor Author

/re-test

@Ashley-wenyizha
Copy link
Contributor Author

/close

@k8s-ci-robot
Copy link
Contributor

@Ashley-wenyizha: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants