Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Helm chart deployment #132

Merged
merged 10 commits into from
Mar 22, 2020
Merged

Add Helm chart deployment #132

merged 10 commits into from
Mar 22, 2020

Conversation

ArieLevs
Copy link
Contributor

Is this a bug fix or adding new feature? feature

What is this PR about? / Why do we need it? adding aws-fsx-csi-driver helm deployment

What testing is done? none

@ArieLevs ArieLevs mentioned this pull request Feb 25, 2020
@k8s-ci-robot
Copy link
Contributor

Welcome @ArieLevs!

It looks like this is your first PR to kubernetes-sigs/aws-fsx-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-fsx-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 25, 2020
@k8s-ci-robot
Copy link
Contributor

Hi @ArieLevs. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Feb 25, 2020
@ArieLevs
Copy link
Contributor Author

I signed it

@leakingtapan
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 26, 2020
@leakingtapan
Copy link
Contributor

@ArieLevs seems CLA check is still complaining

@ArieLevs ArieLevs closed this Feb 26, 2020
@ArieLevs ArieLevs reopened this Feb 26, 2020
@ArieLevs ArieLevs closed this Feb 26, 2020
@ArieLevs ArieLevs reopened this Feb 26, 2020
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Feb 26, 2020
@ArieLevs
Copy link
Contributor Author

@jsafrane @justinsb
Can you please assist with merging this

btw, whats the next step,
i'd like to add a full example on how to install this #115 (comment)

@ArieLevs
Copy link
Contributor Author

ArieLevs commented Mar 4, 2020

@leakingtapan Hi anything i can do to promote this?

Copy link
Contributor

@leakingtapan leakingtapan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late reply. Please also update our e2e test to use the helm chat so that the chart is properly tested.

deploy/kubernetes/helm/README.md Outdated Show resolved Hide resolved
deploy/kubernetes/helm/README.md Outdated Show resolved Hide resolved
deploy/kubernetes/helm/templates/daemonset.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/helm/values.yaml Outdated Show resolved Hide resolved
deploy/kubernetes/helm/values.yaml Outdated Show resolved Hide resolved
@ArieLevs
Copy link
Contributor Author

ArieLevs commented Mar 8, 2020

@leakingtapan
How do i add helm in addition to kustomization in the e2e-test-config.yaml file?

@leakingtapan
Copy link
Contributor

You will need to replace kustomization (which I think it's okay). See here for an example

@ArieLevs
Copy link
Contributor Author

ArieLevs commented Mar 9, 2020

OK then, just thought it should be in addition to kustomize and not replace it.
will test the chart changes and update.

@leakingtapan
Copy link
Contributor

Did you get a chance to update the e2e test?

@ArieLevs
Copy link
Contributor Author

@leakingtapan
helm installation updated, installed and removed successfully from test log.
does the test fail related to this line? https://prow.k8s.io/view/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-fsx-csi-driver/132/pull-aws-fsx-csi-driver-e2e/1238001042168221696#1:build-log.txt%3A1752

@ArieLevs ArieLevs closed this Mar 18, 2020
@ArieLevs ArieLevs reopened this Mar 18, 2020
@leakingtapan
Copy link
Contributor

@ArieLevs We are seeing similar issue here: kubernetes-sigs/aws-ebs-csi-driver#463 and we are still investigating the root cause. Thx for ur patience :)

@leakingtapan
Copy link
Contributor

/retest

@leakingtapan
Copy link
Contributor

Fixed by: #136

@leakingtapan
Copy link
Contributor

/lgtm

@leakingtapan
Copy link
Contributor

/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ArieLevs, leakingtapan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2020
@k8s-ci-robot k8s-ci-robot merged commit a8f3950 into kubernetes-sigs:master Mar 22, 2020
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants