Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CI #172

Merged
merged 15 commits into from
Jun 14, 2021
Merged

Fix CI #172

merged 15 commits into from
Jun 14, 2021

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Mar 11, 2021

Is this a bug fix or adding new feature? fix

What is this PR about? / Why do we need it? CI has been blcoked for a long time and I didn't notice:

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-fsx-csi-driver/166/pull-aws-fsx-csi-driver-e2e/1370094655802183680

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 11, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 11, 2021
@ayberk
Copy link

ayberk commented Mar 31, 2021

/retest

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 9, 2021
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 9, 2021
@wongma7 wongma7 changed the title Run go mod tidy Fix CI Jun 9, 2021
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 10, 2021

some tests say:


Mounting arguments: -t lustre fs-0f1be67812a543d4c.fsx.us-west-2.amazonaws.com@tcp:/fsx /var/lib/kubelet/pods/2745b985-a50b-49a6-8ed9-fe02037bf65c/volumes/kubernetes.io~csi/fsx.csi.aws.com-bd74s/mount
Output: mount.lustre: mount fs-0f1be67812a543d4c.fsx.us-west-2.amazonaws.com@tcp:/fsx at /var/lib/kubelet/pods/2745b985-a50b-49a6-8ed9-fe02037bf65c/volumes/kubernetes.io~csi/fsx.csi.aws.com-bd74s/mount failed: No such device
Are the lustre modules loaded?
Check /etc/modprobe.conf and /proc/filesystems

@wongma7
Copy link
Contributor Author

wongma7 commented Jun 10, 2021

lustre is not in the kernel anymore, need to install.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jun 11, 2021
@wongma7 wongma7 force-pushed the gomodtidy branch 2 times, most recently from 1b49f17 to b2dc1ac Compare June 11, 2021 00:46
@wongma7 wongma7 force-pushed the gomodtidy branch 2 times, most recently from 42cc073 to d8fe80b Compare June 11, 2021 00:54
@wongma7 wongma7 mentioned this pull request Jun 11, 2021
Open
@wongma7 wongma7 force-pushed the gomodtidy branch 2 times, most recently from f9edd35 to dc272e3 Compare June 11, 2021 20:02
@wongma7
Copy link
Contributor Author

wongma7 commented Jun 11, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-fsx-csi-driver/172/pull-aws-fsx-csi-driver-e2e/1403447670432862208

  • subPath should be able to unmount after the subpath directory is deleted has been failing since before CI broke, need to debug and re-enable test soon.
  • Dynamic Provisioning should create a volume on demand with flock mount option not sure why this one would fail, assuming it's a flake and trying again.

@wongma7
Copy link
Contributor Author

wongma7 commented Jun 14, 2021

/retest

@wongma7
Copy link
Contributor Author

wongma7 commented Jun 14, 2021

two Disruptive subPath tests failed in https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_aws-fsx-csi-driver/172/pull-aws-fsx-csi-driver-e2e/1403479400787218432. They might be "real" failures, but should skip Disruptive in CI anyhow. I will leave as TODO to figure out if there is a real bug wrt subPath and fsx

@wuxingro
Copy link
Contributor

lgtm

@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2021
@k8s-ci-robot k8s-ci-robot merged commit 2fa4d6a into kubernetes-sigs:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-nishi d-nishi Awaiting requested review from d-nishi

@leakingtapan leakingtapan Awaiting requested review from leakingtapan

Assignees

@nckturner nckturner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@wongma7 @k8s-ci-robot @ayberk @wuxingro @nckturner