Subdirectory provisioning #272

KanchiShimono · 2022-10-26T11:45:08Z

Is this a bug fix or adding new feature?

New feature.
Attempt to implement subdirectory provisioning requested in #247.

What is this PR about? / Why do we need it?

PR summary:

Add new dynamic provisioning mode (subdirectory provisioning) that creating subdirectory under existing FSx file system.
Add new voulme ID form for subdirectory provisiong to be able to delete subdirectory in DeleteVolume method.
Add new parameters (dnsname, mountname and basedir) of CreateVolumeRequest.
- If dnsname was set, the volume is provisioned as subdirectory mode.
- Subdirectory is created under the basedir.
- basedir is mounted into controller plugin container to create subdirectory.
- subdirectory is mounted into volume claimed container.
Add new volume context for NodePublishVolume/NodeUnPublishVolume.

Why do we need?:

It's useful for usecase that required hundreds GB storage from multiple pod. (Can share form multiple pod)
Fast provisiong. (No need to wait for creating new file system.)
Enable to mount subdirectory on static provisioning.

What testing is done?

Run unit test on my local machine by running make test.
Also deploy and check on my EKS cluster.

linux-foundation-easycla · 2022-10-26T11:45:14Z

The committers listed above are authorized under a signed CLA.

✅ login: KanchiShimono / name: kanchi (94e3f71, e67de3b, 6ad86e4, 34fafc7, cdad808, 57ca45f, 50d7778, f4057e4, 091050a, 0751839, 6ab4ee5, 5bf580d)

k8s-ci-robot · 2022-10-26T11:45:16Z

Welcome @KanchiShimono!

It looks like this is your first PR to kubernetes-sigs/aws-fsx-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-fsx-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2022-10-26T11:45:16Z

Hi @KanchiShimono. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jacobwolfaws · 2022-12-08T18:39:09Z

Hi @KanchiShimono, can you resolve the merge conflicts + rebase the commits you made for readability purposes?

…lishVolume

…enerate-kustomize

k8s-ci-robot · 2022-12-09T20:58:10Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: KanchiShimono
Once this PR has been reviewed and has the lgtm label, please assign jacobwolfaws for approval by writing /assign @jacobwolfaws in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

jacobwolfaws · 2022-12-09T21:28:28Z

/ok-to-test

jacobwolfaws · 2022-12-29T21:10:08Z

charts/aws-fsx-csi-driver/templates/controller-deployment.yaml

+          securityContext:
+            privileged: true


How does this change affect subdirectory provisioning and why is it needed?

jacobwolfaws · 2022-12-29T21:10:29Z

deploy/kubernetes/base/controller-deployment.yaml

+          securityContext:
+            privileged: true


same comment as here: https://github.com/kubernetes-sigs/aws-fsx-csi-driver/pull/272/files#r1059149727

jacobwolfaws · 2022-12-29T21:13:53Z

deploy/kubernetes/base/csidriver.yaml

@@ -6,3 +6,4 @@ metadata:
  name: fsx.csi.aws.com
 spec:
  attachRequired: false
+  fsGroupPolicy: ReadWriteOnceWithFSType


Based on the documentation: https://kubernetes-csi.github.io/docs/support-fsgroup.html it seems like not specifying the fsGroupPolicy policy will default to ReadWriteOnceWithFSType. Is this change needed & could this have any impact on any usecases for csi driver?

kibblerz · 2023-01-11T02:17:39Z

In theory, couldn't a subdirectory be mounted by simply mounting the PV, with a mountname like "mount/subfolder"? I don't have FSx running to test this myself

jacobwolfaws · 2023-01-11T16:06:18Z

In theory, couldn't a subdirectory be mounted by simply mounting the PV, with a mountname like "mount/subfolder"? I don't have FSx running to test this myself

Hi @kibblerz, from my understanding you can mount a subdirectory like you suggested, but the idea behind this PR is being able to provision the subdirectory using the csi driver.

k8s-ci-robot · 2023-01-12T17:50:15Z

@KanchiShimono: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

wongma7 · 2023-01-12T19:19:57Z

pkg/driver/subdir_provisioner.go

+	}()
+
+	// Delete subDir (dnsname@tcp:/mountname/baseDir/subDir) under the tempMountPathPrefix/tempUUID
+	if err := os.RemoveAll(filepath.Join(target, fsxVolume.subDir)); err != nil {


subDir and baseDir may need validation for relative paths. what happens if I set subDir to nonsense like ../

wongma7 · 2023-01-12T19:20:26Z

examples/kubernetes/static_provisioning/README.md

      mountname: [MountName]
+      # set the basedir and subdir if you wanted to mount subdir


in kubernetes the volumehandle must uniquely identify the volume. if you try to mount two PVC+PV on the same node and they have the same volumehandle but different volumeattributes.subdir, I don't think it works. this is why in EFS we removed the path volumeattribute and stuffed everything into the volumehandle like [FileSystemId]:[Path] instead. https://github.com/kubernetes/kubernetes/blob/497e0dfd33b180fcc3855aad794d87f0e429c82c/pkg/volume/csi/csi_plugin.go#L316

k8s-triage-robot · 2023-04-12T19:21:47Z

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle stale
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2023-05-12T19:50:34Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Mark this PR as fresh with /remove-lifecycle rotten
Close this PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2023-06-11T20:04:58Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen
Mark this PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2023-06-11T20:05:03Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

Reopen this PR with /reopen

Mark this PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot requested review from khoang98 and olemarkus October 26, 2022 11:45

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 18, 2022

KanchiShimono added 12 commits December 10, 2022 05:38

Add Provisioner interface used in CSI's CreateVolume/DeleteVolume

234b590

Implement Fileset provisioning

6dc91a5

go mod tidy

13573d4

go mod vendor

acec3aa

Rename fileset to subDir

261f402

Change provisioner field type to Driver

e5bf7cb

Delegate mounting in SubDirProvisioner to NodePublishVolume/NodeUnpub…

5c4d341

…lishVolume

Add storage class parameters validation

075f66d

Add tests for controller plugin

8d3a228

Add tests for node plugin

1dce843

Enable privileged of controller's fsx-plugin container and run make g…

31242df

…enerate-kustomize

Add subdir provisioning examples

1737a50

KanchiShimono force-pushed the subdir-provisioning branch from 5bf580d to 1737a50 Compare December 9, 2022 20:58

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 9, 2022

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 9, 2022

jacobwolfaws reviewed Dec 29, 2022

View reviewed changes

jacobwolfaws mentioned this pull request Dec 29, 2022

Follow up kustomize manifests #286

Closed

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2023

wongma7 reviewed Jan 12, 2023

View reviewed changes

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 12, 2023

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 12, 2023

k8s-ci-robot closed this Jun 11, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Subdirectory provisioning #272

Subdirectory provisioning #272

KanchiShimono commented Oct 26, 2022

linux-foundation-easycla bot commented Oct 26, 2022 •

edited

Loading

k8s-ci-robot commented Oct 26, 2022

k8s-ci-robot commented Oct 26, 2022

jacobwolfaws commented Dec 8, 2022

k8s-ci-robot commented Dec 9, 2022

jacobwolfaws commented Dec 9, 2022

jacobwolfaws Dec 29, 2022

jacobwolfaws Dec 29, 2022

jacobwolfaws Dec 29, 2022

kibblerz commented Jan 11, 2023 •

edited

Loading

jacobwolfaws commented Jan 11, 2023

k8s-ci-robot commented Jan 12, 2023

wongma7 Jan 12, 2023

wongma7 Jan 12, 2023

k8s-triage-robot commented Apr 12, 2023

k8s-triage-robot commented May 12, 2023

k8s-triage-robot commented Jun 11, 2023

k8s-ci-robot commented Jun 11, 2023

		mountname: [MountName]
		# set the basedir and subdir if you wanted to mount subdir

Subdirectory provisioning #272

Subdirectory provisioning #272

Conversation

KanchiShimono commented Oct 26, 2022

linux-foundation-easycla bot commented Oct 26, 2022 • edited Loading

k8s-ci-robot commented Oct 26, 2022

k8s-ci-robot commented Oct 26, 2022

jacobwolfaws commented Dec 8, 2022

k8s-ci-robot commented Dec 9, 2022

jacobwolfaws commented Dec 9, 2022

jacobwolfaws Dec 29, 2022

Choose a reason for hiding this comment

jacobwolfaws Dec 29, 2022

Choose a reason for hiding this comment

jacobwolfaws Dec 29, 2022

Choose a reason for hiding this comment

kibblerz commented Jan 11, 2023 • edited Loading

jacobwolfaws commented Jan 11, 2023

k8s-ci-robot commented Jan 12, 2023

wongma7 Jan 12, 2023

Choose a reason for hiding this comment

wongma7 Jan 12, 2023

Choose a reason for hiding this comment

k8s-triage-robot commented Apr 12, 2023

k8s-triage-robot commented May 12, 2023

k8s-triage-robot commented Jun 11, 2023

k8s-ci-robot commented Jun 11, 2023

linux-foundation-easycla bot commented Oct 26, 2022 •

edited

Loading

kibblerz commented Jan 11, 2023 •

edited

Loading