Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove ebs references from e2e testing #339

Merged
merged 1 commit into from
Jul 13, 2023
Merged

Remove ebs references from e2e testing #339

merged 1 commit into from
Jul 13, 2023

Conversation

jacobwolfaws
Copy link
Contributor

@jacobwolfaws jacobwolfaws commented Jul 11, 2023 •
edited

Is this a bug fix or adding new feature?

What is this PR about? / Why do we need it?
cleaning up the e2e tests + documentation of all ebs stuff

  • git read-tree section is based off the old plan of sharing e2e tests with ebs and pulling them in from the ebs repo
  • EBS specific tests that we already set to false (EBS_CHECK_MIGRATION & EBS_INSTALL_SNAPSHOT) can be removed since there's no plans to share testing with EBS
  • Remove ebs.sh because all it does is house an ebs check migration function
  • Change "ebs" in DRIVER_NAME, CONTAINER_NAME, and GINKGO_FOCUS to "fsx" to reflect that these are part of the fsx-csi-driver testing framework
  • removing windows references since windows isn't supported

What testing is done?

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobwolfaws

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 11, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2023
@jacobwolfaws jacobwolfaws force-pushed the master branch 2 times, most recently from 574c92d to f5d1197 Compare July 12, 2023 13:53
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2023
@jacobwolfaws jacobwolfaws force-pushed the master branch 3 times, most recently from 06ce54e to 47b49fa Compare July 12, 2023 14:31
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 12, 2023
@jacobwolfaws jacobwolfaws changed the title Update k8s in e2e tests & remove mentions of ebs Remove ebs references from e2e testing Jul 12, 2023
@k8s-ci-robot k8s-ci-robot removed the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 12, 2023
@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 12, 2023
hughdanliu
hughdanliu reviewed Jul 12, 2023
View reviewed changes
hack/e2e/run.sh
GINKGO_SKIP=${GINKGO_SKIP:-"\[Disruptive\]"}
GINKGO_NODES=${GINKGO_NODES:-4}
TEST_EXTRA_FLAGS=${TEST_EXTRA_FLAGS:-}

EBS_INSTALL_SNAPSHOT=${EBS_INSTALL_SNAPSHOT:-"false"}
EBS_INSTALL_SNAPSHOT_VERSION=${EBS_INSTALL_SNAPSHOT_VERSION:-"v4.1.1"}
EBS_CHECK_MIGRATION=${EBS_CHECK_MIGRATION:-"false"}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You remove EBS_CHECK_MIGRATION from run.sh, yet it's still included as an option in the command in the README.

@hughdanliu
Copy link

lgtm

@hughdanliu hughdanliu mentioned this pull request Jul 13, 2023
Closed
9 tasks
@khoang98
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2023
@k8s-ci-robot k8s-ci-robot merged commit 6c2d1f3 into kubernetes-sigs:master Jul 13, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughdanliu hughdanliu hughdanliu left review comments

@nckturner nckturner Awaiting requested review from nckturner

@olemarkus olemarkus Awaiting requested review from olemarkus

Assignees

@khoang98 khoang98

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jacobwolfaws @k8s-ci-robot @hughdanliu @khoang98