-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ebs references from e2e testing #339
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobwolfaws The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
574c92d
to
f5d1197
Compare
06ce54e
to
47b49fa
Compare
GINKGO_SKIP=${GINKGO_SKIP:-"\[Disruptive\]"} | ||
GINKGO_NODES=${GINKGO_NODES:-4} | ||
TEST_EXTRA_FLAGS=${TEST_EXTRA_FLAGS:-} | ||
|
||
EBS_INSTALL_SNAPSHOT=${EBS_INSTALL_SNAPSHOT:-"false"} | ||
EBS_INSTALL_SNAPSHOT_VERSION=${EBS_INSTALL_SNAPSHOT_VERSION:-"v4.1.1"} | ||
EBS_CHECK_MIGRATION=${EBS_CHECK_MIGRATION:-"false"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You remove EBS_CHECK_MIGRATION
from run.sh, yet it's still included as an option in the command in the README.
lgtm |
/lgtm |
Is this a bug fix or adding new feature?
What is this PR about? / Why do we need it?
cleaning up the e2e tests + documentation of all ebs stuff
What testing is done?