Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add retry and background run to node taint removal #370

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

jacobwolfaws
Copy link
Contributor

@jacobwolfaws jacobwolfaws commented Jan 10, 2024

Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
Taint removal can have transient failures and should be retried in these cases. This PR also has taint removal run as a goroutine to not impact driver startup.

credits to @ConnorJC3 for his PR in the ebs-csi-driver repo: kubernetes-sigs/aws-ebs-csi-driver#1861
What testing is done?

  • Passed e2e and sanity tests
  • tested on dev cluster and confirmed taints were removed as expected

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 10, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 10, 2024
Copy link
Member

@torredil torredil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold

Changes lgtm - applied hold label to give @ConnorJC3 an opportunity to review before this is merged as he authored a similar change over at aws-ebs-csi-driver. @jacobwolfaws Feel free to unhold at your discretion.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobwolfaws, olemarkus, torredil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [jacobwolfaws,olemarkus,torredil]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ConnorJC3
Copy link

/lgtm

Not an FSx CSI Driver expert, but no obvious defects spotted

@jacobwolfaws
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 17, 2024
@k8s-ci-robot k8s-ci-robot merged commit 7e14664 into kubernetes-sigs:master Jan 17, 2024
5 checks passed
@kamirendawkins
Copy link
Contributor

Just curious @jacobwolfaws if there is an expected release timeline to get this?

@jacobwolfaws
Copy link
Contributor Author

@kamirendawkins we're looking to release a new csi driver version by the end of next week

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants