-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add retry and background run to node taint removal #370
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/hold
Changes lgtm - applied hold label to give @ConnorJC3 an opportunity to review before this is merged as he authored a similar change over at aws-ebs-csi-driver
. @jacobwolfaws Feel free to unhold at your discretion.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobwolfaws, olemarkus, torredil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm Not an FSx CSI Driver expert, but no obvious defects spotted |
/hold cancel |
Just curious @jacobwolfaws if there is an expected release timeline to get this? |
@kamirendawkins we're looking to release a new csi driver version by the end of next week |
Is this a bug fix or adding new feature?
bug fix
What is this PR about? / Why do we need it?
Taint removal can have transient failures and should be retried in these cases. This PR also has taint removal run as a goroutine to not impact driver startup.
credits to @ConnorJC3 for his PR in the ebs-csi-driver repo: kubernetes-sigs/aws-ebs-csi-driver#1861
What testing is done?