-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Affinity to DaemonSet #377
Add Affinity to DaemonSet #377
Conversation
|
Welcome @karaktaka! |
Hi @karaktaka. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Hi @karaktaka, can you rebase the commits into a single commit? |
831e42f
to
4c23523
Compare
Hey @jacobwolfaws, |
Sorry for the delayed response, I think it would make sense to add something like this from the ebs-csi-driver: https://github.com/kubernetes-sigs/aws-ebs-csi-driver/blob/master/charts/aws-ebs-csi-driver/values.yaml#L336-L344 where this is automatically set for users, but affinity is still configurable. Would like to hear your thoughts on that. Otherwise, this looks good to me. |
/ok-to-test |
I just added the values from the ebs chart as I think they make sense like that. |
No worries, sorry I should have been more clear. This restriction doesn't apply to our driver:
only the fargate default is needed for us e2e test failure:
I'll put up a fix for this, is unrelated to your PR |
e63ff26
to
0f19ae2
Compare
@karaktaka sorry for taking so long on this, it seems like I don't get notifications when changes are force-pushed 🤔 . One tiny nit 😅 and I've put up a PR for pinning to a new AMI. |
use correct values add default values for affinity na one line
0f19ae2
to
27eb9b6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
tested and behavior appears to work as expected. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jacobwolfaws, karaktaka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Can a new release of the helm chart be created with this change? |
Is this a bug fix or adding new feature?
Feature: Fixes #376
What is this PR about? / Why do we need it?
See Issue #376
What testing is done?
This chart is currently deployed in our cluster and is working fine (besides, it's a very small change)