-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update aws-sdk-go to v1.23.11 #257
Update aws-sdk-go to v1.23.11 #257
Conversation
Welcome @bdwyertech! |
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Signed CLA |
We need this fix. |
Can you rebase on master? |
Sure, give me a few min.
…On Wed, Aug 28, 2019, 2:40 PM Micah Hausler ***@***.***> wrote:
Can you rebase on master?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#257?email_source=notifications&email_token=AAWV4WNAG6C26AZPDNHJQDLQG3BAJA5CNFSM4INIO2RKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5MCQGQ#issuecomment-525871130>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAWV4WL2FMXRCG3GQUBUBOTQG3BAJANCNFSM4INIO2RA>
.
|
c37880f
to
2054e51
Compare
All set @micahhausler |
Might as well go to latest 1.23.11 -- redoing |
Signed-off-by: Brian Dwyer <Brian.Dwyer@broadridge.com>
Signed-off-by: Brian Dwyer <Brian.Dwyer@broadridge.com>
2054e51
to
0d9c706
Compare
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bdwyertech, nckturner The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sorry for the delay. |
This updates
aws-sdk-go
for a few fixes, namely assume role chaining and assumerole via config file, especially on ECS.aws/aws-sdk-go@8be2a09