Add AWS Access Key ID to log

[otterley]

Add the AWS Access Key ID to the STS response log. This should make it
easier to audit the true identity of the user or process that
authenticated to the cluster.

Fixes #263.

[k8s-ci-robot]

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

---

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
• If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
• Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[k8s-ci-robot]

Welcome @otterley!

It looks like this is your first PR to kubernetes-sigs/aws-iam-authenticator 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-iam-authenticator has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[otterley]

CLA signed

[otterley]

/assign @wongma7

[micahhausler]

Thanks! Just a minor naming nit and request for 1 more test

[micahhausler]

Thanks!

[micahhausler]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, otterley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [micahhausler]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[pepov]

Hi, sorry I'm a bit late to the game, I have a question. The author of the original issue stated this:

If the accessKeyId was available as part of how iam-authenticator generates the username or uid for the audit event, you could correlate it back to the cloudtrail entry.

This pull request does not implement adding the Access Key ID to the response, but simply logging it out.

Then how do I correlate the authenticator log event with the Kubernetes audit log event unambigously if multiple users are making requests assuming the same role concurrently?

[micahhausler]

@pepov I'd welcome a PR that adds the Identity.AccessKeyID to the UserInfo.Extra (see UserInfo.Extra source). That should make its way to the API audit log and allow for the kind of correlation you're looking for.

Full caveat that the proposed change (and this PR) have not made their way to EKS yet, and I don't have a precise timeline for when that might happen

[pepov]

Excellent, I will open a PR!