Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict ClusterRole to readonly IAMIdentityMapping access #287

Merged
merged 1 commit into from
Feb 10, 2020

Conversation

rifelpet
Copy link
Contributor

In the spirit of least privilege security, we shouldn't give write access to the custom resources since it is not needed.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 27, 2020
@rifelpet
Copy link
Contributor Author

/assign @micahhausler

@micahhausler
Copy link
Member

I don't think this is quite right, the server updates the status on CRD objects.

@rdrgmnzs
Copy link

@micahhausler do you think setting patch & update on IAMIdentityMapping/status would be enough? Give of course that the user has pre-created the identity mappings as IAMIdentityMapping. I skimmed over the 2 PRs that looked related to the CRD change and got a sense that would be enough but would like validation from someone more familiar with the code.

I'm in a fairly security conscious environment and can see giving the application performing authentication the ability to create its own identity mapping becoming an issue very fast.

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 28, 2020
In the spirit of least privilege security, we shouldn't give write access to the custom resources since it is not needed, only the status subresource.
@rifelpet
Copy link
Contributor Author

I've updated the ClusterRole to include write access to the status subresource

@rifelpet
Copy link
Contributor Author

rifelpet commented Feb 5, 2020

@micahhausler any update on this? just checking in. TY

Copy link
Member

@micahhausler micahhausler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Can @nckturner take a quick pass and LGTM it?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, rifelpet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 10, 2020
@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 10, 2020
@k8s-ci-robot k8s-ci-robot merged commit aaeee87 into kubernetes-sigs:master Feb 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants