-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrict ClusterRole to readonly IAMIdentityMapping access #287
Restrict ClusterRole to readonly IAMIdentityMapping access #287
Conversation
/assign @micahhausler |
I don't think this is quite right, the server updates the status on CRD objects. |
@micahhausler do you think setting patch & update on I'm in a fairly security conscious environment and can see giving the application performing authentication the ability to create its own identity mapping becoming an issue very fast. |
66e4d5e
to
48a560e
Compare
In the spirit of least privilege security, we shouldn't give write access to the custom resources since it is not needed, only the status subresource.
48a560e
to
cebc22a
Compare
I've updated the ClusterRole to include write access to the status subresource |
@micahhausler any update on this? just checking in. TY |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
Can @nckturner take a quick pass and LGTM it?
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: micahhausler, rifelpet The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
In the spirit of least privilege security, we shouldn't give write access to the custom resources since it is not needed.