Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k8s.io/ dependencies to 1.16.8 #305

Merged
merged 1 commit into from
Mar 17, 2020

Conversation

wongma7
Copy link
Contributor

@wongma7 wongma7 commented Mar 17, 2020

Bump for hygiene and to pick up a newer klog with logtostderr default true.

Details on klog issue:

While working on #303, I ran into crashes like this that happen if you go down some code path where klog tries to log something:

W0317 00:35:43.672444       1 client_config.go:539] Neither --kubeconfig nor --master was specified.  Using the inClusterConfig.  This might not work.                                          
log: exiting because of error: log: cannot create log: open /tmp/aws-iam-authenticator.ip-172-31
-16-168.aws-iam-authenticator.log.WARNING.20200317-003543.1: no such file or directory

The fix is to either set klog.logtostderr true somewhere in the code or to bump klog to a version where it defaults true. Personally prefer to bump.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Mar 17, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wongma7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@nckturner
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 17, 2020
@k8s-ci-robot k8s-ci-robot merged commit 2c46e10 into kubernetes-sigs:master Mar 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants