Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added partition flag #341

Merged
merged 1 commit into from
Oct 6, 2020
Merged

Added partition flag #341

merged 1 commit into from
Oct 6, 2020

Conversation

micahhausler
Copy link
Member

  • Accept STS endpoints provided by the AWS SDK for the given partition
  • Updated HTTP client to not follow redirects
  • Raise error and reject tokens with invalid query parameters

@micahhausler
Added partition flag
1270ed2 
* Accept STS endpoints provided by the AWS SDK for the given partition
* Updated HTTP client to not follow redirects
* Raise error and reject tokens with invalid query parameters
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 6, 2020
@nckturner
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 6, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: micahhausler, nckturner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [micahhausler,nckturner]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9065370 into kubernetes-sigs:master Oct 6, 2020
wongma7
wongma7 reviewed Oct 6, 2020
View reviewed changes
Copy link
Contributor

@wongma7 wongma7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nckturner nckturner mentioned this pull request Oct 6, 2020
Merged
@mattmoyer mattmoyer mentioned this pull request Oct 7, 2020
Closed
@micahhausler micahhausler deleted the feature/partition-isolation branch August 26, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wongma7 wongma7 wongma7 left review comments

@nckturner nckturner nckturner approved these changes

@christopherhein christopherhein Awaiting requested review from christopherhein

Assignees

@nckturner nckturner

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@micahhausler @nckturner @k8s-ci-robot @wongma7