bubble up GOPROXY=direct environment value to Dockerfile

[melnikalex]

Summary

Some VPNs or networks block proxies or caches for golang package artifactories. This change bubbles up the GOPROXY settings in the user's environment to the build in the dockerfile.

Testing

I set GOPROXY to direct and https://goproxy.io, respectfully:

GOPROXY=direct make image
docker buildx build \
                --output=type=docker \
                --platform linux/amd64 \
                --build-arg GOPROXY=direct \
                --tag aws-iam-authenticator:v0.6.0-alpha.0_67db2c300e99b98897f3b7bc61b546619129963e_20220924T024600Z .

…
[+] Building 918.6s (17/17) FINISHED

GOPROXY="https://goproxy.io" make image
docker buildx build \
                --output=type=docker \
                --platform linux/amd64 \
                --build-arg GOPROXY=https://goproxy.io \
                --tag aws-iam-authenticator:v0.6.0-alpha.0_67db2c300e99b98897f3b7bc61b546619129963e_20220924T164456Z .
[+] Building 402.9s (17/17) FINISHED

Omitting the GOPROXY variable entirely works as well.

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: melnikalex / name: Aleksandr Melnik (67db2c3)

[k8s-ci-robot]

Hi @melnikalex. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[nckturner]

I don't think we want to enforce this for everyone as GOPROXY=direct can be significantly slower than using a module proxy. It should be configurable via a setting in the Makefile.

[nckturner]

Please make this configurable.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: melnikalex
Once this PR has been reviewed and has the lgtm label, please assign jaypipes for approval by writing /assign @jaypipes in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

[k8s-ci-robot]

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Reopen this PR with /reopen
• Mark this PR as fresh with /remove-lifecycle rotten
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.