Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #491: Bump aws sdk go to v1.44.107 #493

Merged
merged 3 commits into from
Oct 7, 2022
Merged

Automated cherry pick of #491: Bump aws sdk go to v1.44.107 #493

merged 3 commits into from
Oct 7, 2022

Conversation

jngo2
Copy link
Contributor

@jngo2 jngo2 commented Sep 30, 2022

Cherry pick of #491 on release-0.5.

#491: Bump aws sdk go to v1.44.107

For details on the cherry pick process, see the cherry pick requests page.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jngo2
Once this PR has been reviewed and has the lgtm label, please assign jyotimahapatra for approval by writing /assign @jyotimahapatra in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Sep 30, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @jngo2. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 30, 2022
nckturner
nckturner reviewed Sep 30, 2022
View reviewed changes
go.mod Outdated
sigs.k8s.io/yaml v1.2.0
)

replace (
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are all these replace directives being added?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't paying attention when I was cherry-picking and resolving commits. They were added in the main branch when basic e2e tests were added.

@jngo2 jngo2 force-pushed the automated-cherry-pick-of-#491-upstream-release-0.5 branch from c06dac8 to d89bbbb Compare September 30, 2022 22:17
@jngo2 jngo2 requested review from nckturner and removed request for jaypipes and wongma7 October 1, 2022 00:17
@nckturner
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 1, 2022
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 1, 2022 •
edited
Loading

@jngo2: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-aws-iam-authenticator-e2e d89bbbb link true /test pull-aws-iam-authenticator-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@nckturner
Copy link
Contributor

Hm, we must be missing some commits from this release branch.

@nckturner
Copy link
Contributor

/retest

@nckturner nckturner merged commit 3e81377 into kubernetes-sigs:release-0.5 Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nckturner nckturner Awaiting requested review from nckturner

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jngo2 @k8s-ci-robot @nckturner