Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update CI action versions, remove push trigger #709

Merged

Conversation

bryantbiggs
Copy link
Member

What this PR does / why we need it:

  • Update CI action versions - removes the deprecated runtime warnings such as
image
  • Remove go-version-input due to redundancy warning
image
  • Remove push trigger from dependency review - theres no point in running this when changes are pushed to master since its too late to make any changes at that point and makes it look like master is failing a check
image
  • Replace use of ubuntu-20.04 with ubuntu-latest to ensure OS is kept up to date and for consistency

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 23, 2024
@k8s-ci-robot k8s-ci-robot requested a review from nckturner April 23, 2024 12:15
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 23, 2024
@jyotimahapatra
Copy link
Contributor

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bryantbiggs, jyotimahapatra

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 24, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5b60df3 into kubernetes-sigs:master Apr 24, 2024
8 checks passed
@bryantbiggs bryantbiggs deleted the chore/update-ci-versions branch April 24, 2024 15:23
jaidevmane pushed a commit to jaidevmane/aws-iam-authenticator that referenced this pull request Apr 25, 2024
…ci-versions

chore: Update CI action versions, remove `push` trigger
jaidevmane pushed a commit to jaidevmane/aws-iam-authenticator that referenced this pull request Apr 25, 2024
…ci-versions

chore: Update CI action versions, remove `push` trigger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants