[WIP] Upgrade controller-runtime

[rifelpet]

We've been experiencing some controller bugs where the ALB ingress controller isn't detecting certain changes to ingress annotations. We'll update an ingress annotation and the ALB ingress controller isn't notified about it until the ingress is then updated a second time.

I'm going to try upgrading the controller runtime (and as a result, client-go) to see if that helps. There are breaking changes in the Informers (kubernetes-sigs/controller-runtime#267) that I haven't had an opportunity to fix. If someone wants to step in and fix the remaining issues, feel free. Otherwise I'm hoping to get to it sometime soon.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: rifelpet
To complete the pull request process, please assign m00nf1sh
You can assign the PR to them by writing /assign @m00nf1sh in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[M00nF1sh]

i think it might due to the annotation is parsed separately than the reconcile. (this problem don't exists in V2 though :D). a simple fix(without hard changes) should be force parse annotations before each reconcile :D

[k8s-ci-robot]

@rifelpet: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
pull-aws-alb-ingress-controller-lint	04f74a9	link	/test pull-aws-alb-ingress-controller-lint
pull-aws-alb-ingress-controller-unit-test	04f74a9	link	/test pull-aws-alb-ingress-controller-unit-test
pull-aws-alb-ingress-controller-e2e-test	04f74a9	link	/test pull-aws-alb-ingress-controller-e2e-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[rifelpet]

Based on the log output and my understanding of how controller-runtime works, it seemed to me that the EventHandler wasn't being called during the first ingress update. I may be able to test your v2 implementation soon. It looks like your v2 still uses the controller-runtime 0.1.0, so I should be able to tell whether this issue is fixed or not 👍 regardless I think it would be good to get onto CR 0.2.0

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

[k8s-ci-robot]

@rifelpet: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

[fejta-bot]

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

[k8s-ci-robot]

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.