WIP: Gateway

[smcavallo]

Issue

#1338

Description

Add initial support for Gateway API
In scope:

• NLB/TCPRoute

Observations for discussion:

• Since many of the settings previously configured via annotations can now be defined in native gateway API objects (Ex HTTPRouteRule and GatewayTLSConfig) it may not make sense to continue using the existing annotations where those settings can be defined. since a Gateway can support NLB or ALB (or both) perhaps a more user friendly solution is required.

• • Propose that alb/nlb settings be defined in GatewayClassParameter which is associated with theGatewayClass object instead of annotations. This may be a bit easier to manage and will mean that most if not all the annotations will go away completely.
• • Propose that annotations use new key of gateway.beta.kubernetes.io. instead of alb.ingress.kubernetes.io or service.beta.kubernetes.io because of the above

Checklist

• Added tests that cover your change (if possible)
• Added/modified documentation as required (such as the README.md, or the docs directory)
• Manually tested
• Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

• Backfilled missing tests for code in same general area 🎉
• Refactored something and made the world a better place 🌟

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: smcavallo
Once this PR has been reviewed and has the lgtm label, please assign m00nf1sh for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Hi @smcavallo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-ci-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[kahirokunn]

Awesome!

[johngmyers]

We should build out the validating webhooks at the same time as we define the new types.

We should start out with this under a feature flag so we don't have to maintain compatibility with early mistakes.

This will be a lot easier to review if separated into a series of smaller commit, each building out one component.

[kahirokunn]

Any progress?

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[blakepettersson]

/remove-lifecycle stale

[Aym3nTN]

Any progress?

[mithunkrb]

Hi,

We are also planning to migrate from Ingress to Gateway API for our cluster however, we are currently blocked as currently we don't have any spec parameter in GatewayClass/Gateway which is equivalent to service annotations(for example: service.beta.kubernetes.io/aws-load-balancer-type: "external", , service.beta.kubernetes.io/aws-load-balancer-security-groups: "sg-0bfa8da2aca87a2f2") to let the LB reconciliation picked by latest AWS LBC controllers to deploy NLB instead of in-tree controller(classic).

Wondering if we have any update on this?

Please let me know if you need a helping hand on this PR, I can try to contribute

[jdoylei]

Hi @smcavallo, is this PR (Add initial support for Gateway API) still something you're working on / interested in? It seems like @johngmyers had some suggestions a couple months later, but this PR doesn't show activity after that.

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle rotten
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

[blakepettersson]

/remove-lifecycle rotten

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[zac-nixon]

It seems this PR has been abandoned. I'm working on a Gateway API integration right now and I'll close this out to prevent further confusion.

[jdoylei]

It seems this PR has been abandoned. I'm working on a Gateway API integration right now and I'll close this out to prevent further confusion.

@zac-nixon - it's great to hear you're working on this. Will your work be attached to the same GitHub issue about Gateway API, #1338? If you have a PR or commits or docs, could you please leave a link in a PR comment here, just for a trail to follow? Thanks for posting your comment to this PR.