Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CVE-2023-44487: disable HTTP2 for webhook server and bump controller-runtime to 0.14.7 #3452

Closed
wants to merge 0 commits into from

Conversation

alebedev87
Copy link
Contributor

Issue

N/A

Description

This PR addresses the HTTP2 Rapid Reset (CVE-2023-44487) by:

Before the change:

$ oc get pods albc-aws-load-balancer-controller-666676c7bf-df7rp -o yaml | yq .spec.containers[0].args
- --cluster-name=alebedev-1026-csv9b
- --ingress-class=alb
- --aws-region=us-east-2
- --aws-vpc-id=vpc-09f727cc56ff10c9f

$ oc get svc aws-load-balancer-webhook-service
NAME                                TYPE           CLUSTER-IP       EXTERNAL-IP                                                               PORT(S)         AGE
aws-load-balancer-webhook-service   LoadBalancer   172.30.165.126   af2495b6963494f6e9b7b88a65e5eaf0-1803416629.us-east-2.elb.amazonaws.com   443:31795/TCP   40m

$ curl -kv https://af2495b6963494f6e9b7b88a65e5eaf0-1803416629.us-east-2.elb.amazonaws.com 2>&1 | grep 'ALPN'
* ALPN, offering h2
* ALPN, offering http/1.1
* ALPN, server accepted to use h2

After:

$ oc get pods albc-aws-load-balancer-controller-7bd4c4dff7-ksfx9 -o yaml | yq .spec.containers[0].args
- --cluster-name=alebedev-1026-csv9b
- --ingress-class=alb
- --aws-region=us-east-2
- --aws-vpc-id=vpc-09f727cc56ff10c9f
- --webhook-disable-http2

$ curl -kv https://af2495b6963494f6e9b7b88a65e5eaf0-1803416629.us-east-2.elb.amazonaws.com 2>&1 | grep 'ALPN'
* ALPN, offering h2
* ALPN, offering http/1.1
* ALPN, server accepted to use http/1.1

Note: A new flag for the HTTP2 disabling is added. I'm fine to remove the flag if it's not the common way.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 26, 2023
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @alebedev87. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Oct 26, 2023
@alebedev87 alebedev87 closed this Oct 26, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: alebedev87

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants