Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v2.7.2 - Cherry picked the commits from main #3620

Merged
merged 10 commits into from
Mar 22, 2024

Conversation

shraddhabang
Copy link
Collaborator

Description

Release v2.7.2 - Cherry picked the commits from main

Ran and verified E2E tests on the test image with these commits.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 20, 2024
@k8s-ci-robot k8s-ci-robot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Mar 20, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 18.18182% with 18 lines in your changes are missing coverage. Please review.

Project coverage is 55.29%. Comparing base (f689bbd) to head (9ae4080).

Files Patch % Lines
pkg/ingress/cert_discovery.go 0.00% 6 Missing ⚠️
pkg/service/model_build_load_balancer.go 40.00% 6 Missing ⚠️
pkg/deploy/elbv2/tagging_manager.go 0.00% 2 Missing ⚠️
pkg/ingress/model_builder.go 0.00% 2 Missing ⚠️
pkg/config/ingress_config.go 0.00% 1 Missing ⚠️
pkg/deploy/elbv2/listener_manager.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           release-2.7    #3620      +/-   ##
===============================================
- Coverage        55.34%   55.29%   -0.05%     
===============================================
  Files              149      149              
  Lines             8973     8988      +15     
===============================================
+ Hits              4966     4970       +4     
- Misses            3668     3679      +11     
  Partials           339      339              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ikosenn
Copy link
Contributor

ikosenn commented Mar 21, 2024

Hey @shraddhabang is it possible to include commit ac21af6?

@shraddhabang
Copy link
Collaborator Author

shraddhabang commented Mar 21, 2024

Hey @shraddhabang is it possible to include commit ac21af6?

Hey @ikosenn , We are planning release of your commit for v2.8.0 as its a big change for a patch release and we need to get internal security sign off for this feature addition. The current ETA for next minor release is end of April.

@ikosenn
Copy link
Contributor

ikosenn commented Mar 21, 2024

Hey @shraddhabang is it possible to include commit ac21af6?

Hey @ikosenn , We are planning release of your commit for v2.8.0 as its a big change for a patch release and we need to get internal security sign off for this feature addition. The current ETA for next minor release is end of April.

Thanks for the quick response. Makes it sound serious. Might you have an ETA on when 2.8.0 might be out?

@shraddhabang
Copy link
Collaborator Author

Hey @shraddhabang is it possible to include commit ac21af6?

Hey @ikosenn , We are planning release of your commit for v2.8.0 as its a big change for a patch release and we need to get internal security sign off for this feature addition. The current ETA for next minor release is end of April.

Thanks for the quick response. Makes it sound serious. Might you have an ETA on when 2.8.0 might be out?

No worries. This is a standard process for such a large contribution. We are tracking it for end of April or early May.

@ikosenn
Copy link
Contributor

ikosenn commented Mar 21, 2024

Hey @shraddhabang is it possible to include commit ac21af6?

Hey @ikosenn , We are planning release of your commit for v2.8.0 as its a big change for a patch release and we need to get internal security sign off for this feature addition. The current ETA for next minor release is end of April.

Thanks for the quick response. Makes it sound serious. Might you have an ETA on when 2.8.0 might be out?

No worries. This is a standard process for such a large contribution. We are tracking it for end of April or early May.

Thanks. Will keep an eye on it.

Copy link
Collaborator

@M00nF1sh M00nF1sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 22, 2024
@M00nF1sh M00nF1sh merged commit 61e0135 into kubernetes-sigs:release-2.7 Mar 22, 2024
7 of 9 checks passed
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: M00nF1sh, shraddhabang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.