Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TargetGroupBinding now support targetGroupName - #2655 refresh #3903

Merged
merged 9 commits into from
Dec 6, 2024
Merged

TargetGroupBinding now support targetGroupName - #2655 refresh #3903

merged 9 commits into from
Dec 6, 2024

Conversation

fatmcgav
Copy link
Contributor

@fatmcgav fatmcgav commented Oct 18, 2024 •
edited
Loading

Issue

Partially solves #2373
#3586
#3819

Description

This PR contains the changes from #2655 rebased against the latest main and updated to support aws-sdk-go-v2.

All credit goes to @marcosdiez for the original PR and changes.

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the docs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@k8s-ci-robot
Copy link
Contributor

Welcome @fatmcgav!

It looks like this is your first PR to kubernetes-sigs/aws-load-balancer-controller 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/aws-load-balancer-controller has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 18, 2024
@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented Oct 18, 2024 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@k8s-ci-robot
Copy link
Contributor

Hi @fatmcgav. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Oct 18, 2024
@fatmcgav fatmcgav mentioned this pull request Oct 18, 2024
Closed
6 tasks
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 18, 2024
@fatmcgav
Copy link
Contributor Author

cc @johngmyers As you reviewed the previous PR 👍

This was referenced Oct 18, 2024
Open
Open
@shraddhabang
Copy link
Collaborator

shraddhabang commented Oct 23, 2024 •
edited
Loading

/ok-to-test

@fatmcgav
Copy link
Contributor Author

fatmcgav commented Oct 23, 2024 •
edited by shraddhabang
Loading

/ok-to-test

Hey @shraddhabang ... Thanks for ok'ing... I think you missed the last t though ;)

@shraddhabang shraddhabang added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 23, 2024
@fatmcgav
Copy link
Contributor Author

Hey @shraddhabang

Thanks for running the tests. I'm glad they all passed :)
Hopefully someone can review this soon and assuming all good then get it merged and released 🤞

@wweiwei-li
Copy link
Collaborator

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 28, 2024
@fatmcgav
Copy link
Contributor Author

fatmcgav commented Nov 5, 2024

Thanks for the lgtm @wweiwei-li ... What's next to get this merged and released?

@fatmcgav
Copy link
Contributor Author

fatmcgav commented Nov 5, 2024

I note that #3853 has recently been merged and released.

I suspect this feature will further enhance and simplify the multi-cluster capabilities :)

@fatmcgav
Copy link
Contributor Author

@shraddhabang / @wweiwei-li Nudge on this one ❤️

@MarcusDunn
Copy link

@shraddhabang / @wweiwei-li could you take a look at this / what it would take to get it merged? This change would be a huge QoL improvement for our deployments.

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 2, 2024
@fatmcgav
Copy link
Contributor Author

fatmcgav commented Dec 2, 2024

@shraddhabang / @wweiwei-li I've rebased this branch from master, so please can we get this re-approved, merged and released :) ❤️

@shraddhabang
Copy link
Collaborator

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fatmcgav, shraddhabang, zac-nixon
Once this PR has been reviewed and has the lgtm label, please assign oliviassss for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shraddhabang shraddhabang merged commit 283ebee into kubernetes-sigs:main Dec 6, 2024
4 of 5 checks passed
@fatmcgav
Copy link
Contributor Author

fatmcgav commented Dec 6, 2024

🥳 Thanks @shraddhabang

@fatmcgav fatmcgav deleted the targetGroupName branch December 6, 2024 18:08
@fatmcgav
Copy link
Contributor Author

@shraddhabang Are you able to confirm when the next release is scheduled for? 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shraddhabang shraddhabang shraddhabang approved these changes

@zac-nixon zac-nixon zac-nixon approved these changes

@M00nF1sh M00nF1sh Awaiting requested review from M00nF1sh

@oliviassss oliviassss Awaiting requested review from oliviassss

@wweiwei-li wweiwei-li Awaiting requested review from wweiwei-li

Assignees

@shraddhabang shraddhabang

@wweiwei-li wweiwei-li

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@fatmcgav @k8s-ci-robot @shraddhabang @wweiwei-li @MarcusDunn @zac-nixon @marcosdiez