Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Update dependencies cloud provider azure #1662

Merged
merged 1 commit into from
Dec 22, 2022
Merged

chore: Update dependencies cloud provider azure #1662

merged 1 commit into from
Dec 22, 2022

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Dec 16, 2022

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 16, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @cvvz!

It looks like this is your first PR to kubernetes-sigs/azuredisk-csi-driver 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/azuredisk-csi-driver has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 16, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @cvvz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cvvz cvvz changed the title chore:Update dependencies cloud provider azure chore: Update dependencies cloud provider azure Dec 16, 2022
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 16, 2022
@andyzhangx andyzhangx removed the request for review from edreed December 17, 2022 07:44
@andyzhangx andyzhangx force-pushed the update-dependencies-cloud-provider-azure branch from 7f6a81b to 13a9fae Compare December 17, 2022 09:03
@andyzhangx
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 17, 2022
@andyzhangx andyzhangx force-pushed the update-dependencies-cloud-provider-azure branch from 3f1da21 to 1c1bb2d Compare December 17, 2022 11:29
@cvvz
Copy link
Member Author

cvvz commented Dec 17, 2022

/retest

4 similar comments
@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/retest

@cvvz
Copy link
Member Author

cvvz commented Dec 20, 2022

/retest

@cvvz cvvz force-pushed the update-dependencies-cloud-provider-azure branch from 55821b6 to e306d38 Compare December 20, 2022 12:04
@andyzhangx
Copy link
Member

/test pull-azuredisk-csi-driver-e2e-capz

@andyzhangx
Copy link
Member

/retest

@cvvz cvvz force-pushed the update-dependencies-cloud-provider-azure branch 4 times, most recently from 5d01b8c to 5967801 Compare December 21, 2022 07:20
@cvvz
chore: update dependencies of cloud-provider-azure
115c46e 
boilerplate

fix ut

use go1.19

Revert "use go1.19"

This reverts commit a8cb5db.

test: fix trivy action

test: fix golint error

fix: golint error

test: fix golint error

test: fix golint

test: fix golint

test: fix golint

test: fix golint

use ginkgo v2

use latest mount-utils

fix e2e

fake mounter

set framework namespace podSecurity enforcelevel to privileged

fix verify

add ginkgo.timeout

fix
@cvvz cvvz force-pushed the update-dependencies-cloud-provider-azure branch from 5967801 to 115c46e Compare December 21, 2022 07:22
@cvvz
Copy link
Member Author

cvvz commented Dec 21, 2022

/retest

1 similar comment
@cvvz
Copy link
Member Author

cvvz commented Dec 21, 2022

/retest

@cvvz
Copy link
Member Author

cvvz commented Dec 21, 2022

/retest

andyzhangx
andyzhangx approved these changes Dec 22, 2022
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
thanks, actually I mean it could be squashed to fewer commits, e.g. vendor change, e2e test fix, windows interface fix, etc. That would be more clear, it's not necessary always to be one commit in one PR.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 22, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit e532f57 into kubernetes-sigs:master Dec 22, 2022
@cvvz cvvz deleted the update-dependencies-cloud-provider-azure branch December 22, 2022 05:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cvvz @k8s-ci-robot @andyzhangx