Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-1.28] fix: cloned volume could not be recognized on Windows node when source volume is mounted on the same node #1914

Conversation

k8s-infra-cherrypick-robot

This is an automated cherry-pick of #1909

/assign andyzhangx

fix: ensure that readonly is disabled when disks are brought online

fix

test: set WaitForFirstConsumer for volume clone test

fix e2e test failure

fix windows test

fix windows test failure

revert WaitForFirstConsumer change

fix test

set larger waiting time befor cloning volume

set warnning

test: fix comments
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jul 28, 2023
@andyzhangx
Copy link
Member

/retest

4 similar comments
@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, k8s-infra-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit 2ac5183 into kubernetes-sigs:release-1.28 Jul 30, 2023
10 checks passed
@lippertmarkus
Copy link

@andyzhangx thanks! Can you estimate when is this released to AKS?

@andyzhangx
Copy link
Member

@andyzhangx thanks! Can you estimate when is this released to AKS?

@lippertmarkus we will publish a new v1.28.2 release this week, and rollout on aks would be on 0813 or 0820 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants