Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade ginkgo to v2 #2114

Merged
merged 2 commits into from
Dec 11, 2023

Conversation

cvvz
Copy link
Member

@cvvz cvvz commented Dec 7, 2023

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Dec 7, 2023
@andyzhangx andyzhangx removed the request for review from edreed December 10, 2023 15:38
@andyzhangx
Copy link
Member

/retest

@andyzhangx
Copy link
Member

@cvvz could you investigate the two failures:
https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_azuredisk-csi-driver/2114/pull-azuredisk-csi-driver-external-e2e-single-az/1734023597623611392/build-log.txt

�[38;5;9m�[1mSummarizing 2 Failures:�[0m
  �[38;5;9m[FAIL]�[0m �[0mExternal Storage [Driver: test.csi.azure.com] �[38;5;243m[Testpattern: Dynamic PV (default fs)] volumes �[38;5;9m�[1m[It] should allow exec of files on the volume�[0m
  �[38;5;243mtest/e2e/storage/testsuites/volumes.go:154�[0m
  �[38;5;9m[FAIL]�[0m �[0mExternal Storage [Driver: test.csi.azure.com] �[38;5;243m[Testpattern: Dynamic PV (block volmode)] multiVolume [Slow] �[38;5;9m�[1m[It] should concurrently access the volume and its clone from pods on the same node [LinuxOnly][Feature:VolumeSourceXFS]�[0m
  �[38;5;243mtest/e2e/storage/testsuites/multivolume.go:126�[0m

�[38;5;9m�[1mRan 93 of 7345 Specs in 1691.719 seconds�[0m
�[38;5;9m�[1mFAIL!�[0m -- �[38;5;10m�[1m91 Passed�[0m | �[38;5;9m�[1m2 Failed�[0m | �[38;5;11m�[1m0 Pending�[0m | �[38;5;14m�[1m7252 Skipped�[0m

@andyzhangx
Copy link
Member

/retest

1 similar comment
@cvvz
Copy link
Member Author

cvvz commented Dec 11, 2023

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 11, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, cvvz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 11, 2023
@andyzhangx andyzhangx merged commit d2a6d0e into kubernetes-sigs:master Dec 11, 2023
22 of 26 checks passed
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Dec 11, 2023

@cvvz: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-capz 8839e4b link unknown /test pull-azuredisk-csi-driver-e2e-capz
pull-azuredisk-csi-driver-external-e2e-single-az 8839e4b link unknown /test pull-azuredisk-csi-driver-external-e2e-single-az

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants