Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chores: put lint args into golangci-lint config file #2124

Merged
merged 1 commit into from
Dec 15, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/static.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -16,4 +16,3 @@ jobs:
uses: golangci/golangci-lint-action@v3
with:
version: v1.54
args: -E=gofmt,unused,ineffassign,revive,misspell,exportloopref,asciicheck,bodyclose,depguard,dogsled,durationcheck,errname,forbidigo -D=staticcheck --timeout=30m0s
andyzhangx marked this conversation as resolved.
Show resolved Hide resolved
18 changes: 15 additions & 3 deletions .golangci.yml
Original file line number Diff line number Diff line change
@@ -1,13 +1,25 @@
run:
andyzhangx marked this conversation as resolved.
Show resolved Hide resolved
deadline: 10m
deadline: 30m

linters:
disable:
- typecheck
- structcheck
- staticcheck
enable:
- golint

- gofmt
- unused
- ineffassign
- revive
- misspell
- exportloopref
- asciicheck
- bodyclose
- depguard
- dogsled
- durationcheck
- errname
- forbidigo
linters-settings:
depguard:
rules:
Expand Down
Loading