Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: Extract kubeclient from provider package. #2126

Merged
merged 1 commit into from
Dec 29, 2023
Merged

Refactor: Extract kubeclient from provider package. #2126

merged 1 commit into from
Dec 29, 2023

Conversation

MartinForReal
Copy link
Contributor

@MartinForReal MartinForReal commented Dec 14, 2023 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Refactor: Extract kubeclient from provider package.
Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

none

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot requested review from cvvz and edreed December 14, 2023 10:27
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 14, 2023
@MartinForReal
Copy link
Contributor Author

blocked by #2123

@MartinForReal MartinForReal changed the title Refactor: Extract kubeclient from provider package. [wip]Refactor: Extract kubeclient from provider package. Dec 14, 2023
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 14, 2023
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Dec 26, 2023
@MartinForReal MartinForReal changed the title [wip]Refactor: Extract kubeclient from provider package. Refactor: Extract kubeclient from provider package. Dec 26, 2023
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 26, 2023
@MartinForReal
Copy link
Contributor Author

/retest

@andyzhangx andyzhangx removed the request for review from edreed December 27, 2023 03:12
@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
refactor:extract kubeclient
1d9f913 
Signed-off-by: Fan Shang Xiang <shafan@microsoft.com>
@MartinForReal
Copy link
Contributor Author

/retest

4 similar comments
@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

@MartinForReal
Copy link
Contributor Author

/retest

andyzhangx
andyzhangx approved these changes Dec 28, 2023
View reviewed changes
Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 28, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, MartinForReal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 28, 2023
@MartinForReal
Copy link
Contributor Author

/retest

1 similar comment
@MartinForReal
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit b7ace18 into kubernetes-sigs:master Dec 29, 2023
26 checks passed
@MartinForReal MartinForReal deleted the shafan/kubeclient branch December 29, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx andyzhangx approved these changes

@cvvz cvvz Awaiting requested review from cvvz

Assignees

@andyzhangx andyzhangx

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinForReal @k8s-ci-robot @andyzhangx