Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support more ZRS skus in volume affinity #2171

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

andyzhangx
Copy link
Member

@andyzhangx andyzhangx commented Jan 31, 2024

What type of PR is this?
/kind feature

What this PR does / why we need it:
feat: support more ZRS skus
In the future, more ZRS skus would be provided, this PR makes sure that new ZRS skus could be supported in the driver without code change.

Which issue(s) this PR fixes:

Fixes #

Requirements:

Special notes for your reviewer:

Release note:

feat: support more ZRS skus

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2024
@andyzhangx
Copy link
Member Author

/retest

4 similar comments
@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@andyzhangx
Copy link
Member Author

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 1, 2024

@andyzhangx: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-integration 58f50cc link true /test pull-azuredisk-csi-driver-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit b7064b3 into kubernetes-sigs:master Feb 1, 2024
24 of 26 checks passed
@andyzhangx
Copy link
Member Author

/cherrypick release-1.29

@andyzhangx
Copy link
Member Author

/cherrypick release-1.28

@andyzhangx
Copy link
Member Author

/cherrypick release-1.27

@andyzhangx
Copy link
Member Author

/cherrypick release-1.26

@k8s-infra-cherrypick-robot

@andyzhangx: #2171 failed to apply on top of branch "release-1.29":

Applying: feat: support more ZRS skus
Using index info to reconstruct a base tree...
M	pkg/azuredisk/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/controllerserver.go
CONFLICT (content): Merge conflict in pkg/azuredisk/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: support more ZRS skus
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.29

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #2171 failed to apply on top of branch "release-1.28":

Applying: feat: support more ZRS skus
Using index info to reconstruct a base tree...
M	pkg/azuredisk/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/controllerserver.go
CONFLICT (content): Merge conflict in pkg/azuredisk/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: support more ZRS skus
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #2171 failed to apply on top of branch "release-1.27":

Applying: feat: support more ZRS skus
Using index info to reconstruct a base tree...
M	pkg/azuredisk/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/controllerserver.go
CONFLICT (content): Merge conflict in pkg/azuredisk/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: support more ZRS skus
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.27

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-infra-cherrypick-robot

@andyzhangx: #2171 failed to apply on top of branch "release-1.26":

Applying: feat: support more ZRS skus
Using index info to reconstruct a base tree...
M	pkg/azuredisk/controllerserver.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/azuredisk/controllerserver.go
CONFLICT (content): Merge conflict in pkg/azuredisk/controllerserver.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 feat: support more ZRS skus
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherrypick release-1.26

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@andyzhangx andyzhangx changed the title feat: support more ZRS skus feat: support more ZRS skus in volume affinity Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants