Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.30] fix: Workload identity is not working. #2236

Merged
merged 1 commit into from
Mar 24, 2024
Merged

[release-1.30] fix: Workload identity is not working. #2236

merged 1 commit into from
Mar 24, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #2233

/assign andyzhangx

fix: Workload identity is not working.

@cvvz
Squashed commit of the following:
fd3e6d3 
commit e5fc454
Author: weizhichen <weizhichen@microsoft.com>
Date:   Fri Mar 22 02:50:20 2024 +0000

    fix ut

commit c187396
Merge: db238de fda1d0a
Author: weizhichen <weizhichen@microsoft.com>
Date:   Fri Mar 22 02:33:37 2024 +0000

    Merge branch 'master' of github.com:kubernetes-sigs/azuredisk-csi-driver into fix-workload-identity

commit db238de
Author: weizhichen <weizhichen@microsoft.com>
Date:   Wed Mar 20 09:07:45 2024 +0000

    add ut

commit 68c19d6
Author: weizhichen <weizhichen@microsoft.com>
Date:   Wed Mar 20 06:30:58 2024 +0000

    fix
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Mar 24, 2024
Merged
4 tasks
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 24, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: k8s-infra-cherrypick-robot
Once this PR has been reviewed and has the lgtm label, please assign edreed for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@andyzhangx
Copy link
Member

/retest

1 similar comment
@andyzhangx
Copy link
Member

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Mar 24, 2024 •
edited
Loading

@k8s-infra-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess fd3e6d3 link true /test pull-azuredisk-csi-driver-e2e-capz-windows-2019-hostprocess

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx andyzhangx merged commit 86db80a into kubernetes-sigs:release-1.30 Mar 24, 2024
23 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andyzhangx andyzhangx Awaiting requested review from andyzhangx

@cvvz cvvz Awaiting requested review from cvvz

Assignees

@andyzhangx andyzhangx

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @andyzhangx @cvvz