Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(helm) Allow setting an alternate name of the configmap for the azure credential path #1363

Merged

Conversation

mtougeron
Copy link
Member

What type of PR is this?

/kind feature

What this PR does / why we need it:

This allows setting an name for the azure credential configmap. This allows this chart and the azuredisk-csi-driver chart to not conflict with each other over the name of the configmap (associated PR kubernetes-sigs/azuredisk-csi-driver#1935). This is important for a GitOps workflow where we don't want an order of operations dependency between these two charts.

We install these charts via a wrapper chart that installs the additional configmap manifest with the appropriate config information. However, both charts cannot contain that extra manifest or Argo CD would create warnings that more than 1 chart owns the configmap. This means that the azuredisk and azurefile wrapper charts would need to install the configmap with different names.

Otherwise, if only one of the two wrapper charts installed the additional manifest, there would be an order of operations dependency on the two charts. This creates additional complexity that Argo CD does not have a mechanism to handle.

Which issue(s) this PR fixes:
Fixes # n/a

Requirements:

Special notes for your reviewer:

Release note:

Allow setting an alternate name of the configmap for the azure credential path in the helm chart

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 14, 2023
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Aug 14, 2023
Copy link

@adriananeci adriananeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@adriananeci: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mtougeron
Copy link
Member Author

flake on the test net/http: TLS handshake timeout

/test pull-azurefile-csi-driver-e2e-migration-windows

@mtougeron
Copy link
Member Author

I'm not seeing anything related to my PR in these errors. The manifest is rendering properly as expected. Going to retest.

/retest-required

@andyzhangx
Copy link
Member

/retest

Copy link
Member

@andyzhangx andyzhangx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andyzhangx, mtougeron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 15, 2023
@k8s-ci-robot
Copy link
Contributor

@mtougeron: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-azurefile-csi-driver-e2e-migration-windows b5e110b link unknown /test pull-azurefile-csi-driver-e2e-migration-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@andyzhangx
Copy link
Member

/retest

@andyzhangx andyzhangx merged commit 4046d86 into kubernetes-sigs:master Aug 15, 2023
@mtougeron mtougeron deleted the configurable-configmap-name branch August 15, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants