-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Boskos does not allow duplicate resource name even for different types #14
Comments
Issues go stale after 90d of inactivity. If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or fejta. |
I think we need to handle Release and GetResource: like https://github.com/kubernetes-sigs/boskos/blob/master/ranch/storage.go#L102:19 and https://github.com/kubernetes-sigs/boskos/blob/master/ranch/ranch.go#L279 |
/lifecycle frozen |
Pinning the links from the previous comment to a specific commit, because $ git log --date=short --format='%ad %h %s' --first-parent | grep -B1 '2020-08'
2020-09-03 c0841a5 Merge pull request #39 from ixdy/go1.15.1
2020-08-18 984516e Merge pull request #38 from ixdy/boskos-janitor-logging-sinks So: |
I was poking around at this today, and I feel like the solution is to bump the resources:
- type: a
names:
- b-c
- type: a-b
names:
- c But I can't think of a simple guard for that, because any delimiters we could use could also be in the type or name. We could hash However looking through the docs on CRD versions, I don't actually see any provision for mutating resource names. This might be a "drain the existing leases, delete all the existing ResourceObject, install the new CRD, and then push your config into new ResourceObjects" sort of thing. Or can we assume that the only thing touching these ResourceObjects is Boskos itself and wire the conversion into the reaper or some other process that is iterating over ResourceObjects? |
Originally filed as kubernetes/test-infra#15054 by @amwat
results in
{"error":"duplicated resource name: foo","level":"fatal","msg":"failed to create ranch!" }
This seems like something we should support?
/cc @krzyzacy @ixdy @sebastienvas
The text was updated successfully, but these errors were encountered: