-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Add e2e test and template for K8s version upgrade #164
Conversation
78626b7
to
01ccf50
Compare
e47d368
to
f481cf0
Compare
f481cf0
to
760b4a8
Compare
@willie-yao @mboersma Could you guys take a look at this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a minor nit from my end. Also, are you opting to maintain these templates manually vs pulling them from CAPI and modifying them? I know patching the list of variables is tricky so either way works.
@willie-yao The process right now would be to pull the Cluster and ClusterClass template from CAPI and manually change the pod security and the label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm++
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Jont828, mboersma, willie-yao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it: Add e2e test and template for K8s version upgrade to verify that version upgrade works.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #