Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🌱 Bump CAPI to v1.7.4 #263

Merged
merged 1 commit into from
Jul 31, 2024
Merged

🌱 Bump CAPI to v1.7.4 #263

merged 1 commit into from
Jul 31, 2024

Conversation

mboersma
Copy link
Contributor

What this PR does / why we need it:

Updates CAPI to v1.7.4 and all that entails. Also bumps the old version used in the clusterctl upgrade test to v1.6.7.

Which issue(s) this PR fixes:

N/A, but see #260 for prior art.

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jul 11, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 11, 2024
@mboersma
Copy link
Contributor Author

/retitle 🌱 Bump CAPI to v1.7.4

@k8s-ci-robot k8s-ci-robot changed the title Bump CAPI to v1.7.4 🌱 Bump CAPI to v1.7.4 Jul 11, 2024
@mboersma
Copy link
Contributor Author

/retest

Pod scheduling timeout

@mboersma
Copy link
Contributor Author

ping @Jont828

This was referenced Jul 15, 2024
Closed
Closed
@mboersma
Copy link
Contributor Author

/retest

@mboersma
Copy link
Contributor Author

/assign @jackfrancis @willie-yao

Could someone please review this? It's simple and been sitting here for two weeks. Thanks!

willie-yao
willie-yao approved these changes Jul 29, 2024
View reviewed changes
Copy link

@willie-yao willie-yao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Sorry for missing this!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 29, 2024
@Jont828
Copy link
Contributor

Jont828 commented Jul 29, 2024

/lgtm
/approve

@mboersma
Copy link
Contributor Author

Seems like the "verify" checks are failing consistently, all because I forgot an emoji when first submitting the PR... I'll rebase and push, sorry for the churn!

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 30, 2024
@mboersma
Copy link
Contributor Author

/retitle 🌱 Bump CAPI to v1.7.4

wtf

@mboersma mboersma changed the title 🌱 Bump CAPI to v1.7.4 🌱 Bump CAPI to v1.7.4 Jul 30, 2024
@Jont828
Copy link
Contributor

Jont828 commented Jul 31, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 31, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Jont828, mboersma, willie-yao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 1192491 into kubernetes-sigs:main Jul 31, 2024
17 of 18 checks passed
@mboersma mboersma deleted the bump-capi branch July 31, 2024 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willie-yao willie-yao willie-yao approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@jackfrancis jackfrancis

@Jont828 Jont828

@willie-yao willie-yao

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
CAPZ Planning
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mboersma @Jont828 @k8s-ci-robot @willie-yao @jackfrancis