Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clusterctl move fails because of delete webhook #140

Closed
christianang opened this issue May 9, 2023 · 0 comments
Closed

clusterctl move fails because of delete webhook #140

christianang opened this issue May 9, 2023 · 0 comments
Milestone

Comments

@christianang
Copy link
Contributor

Context

When clusterctl move runs it attempts to delete everything off the source cluster. This currently fails because it may attempt to delete the pool before it deletes all the ipaddresses and there doesn't seem to be a way to control delete order. So it will error on the validate delete webhook, which #124 added functionality to check that there are no in use IPs before allowing a pool to be deleted.

Potential solution

For future cluster-api releases (1.5+), there was an annotation added that a validate delete webhook can look for to potentially allow the validation to be skipped called: clusterctl.cluster.x-k8s.io/delete-for-move (via kubernetes-sigs/cluster-api#8322).

For the current cluster-api release and below (1.4.x), there doesn't seem to be a good way to do this so I think we need to add our own annotation that allows the delete validation to be skipped, which a user could have on their pool before a move e.g ipam.cluster.x-k8s.io/skip-validate-delete-webhook.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants